Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to raw string to avoid unicode escape #27

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Change to raw string to avoid unicode escape #27

merged 2 commits into from
Feb 24, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Feb 24, 2021

Purpose

Per SO, changed to raw string. Closes #24.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

There are no tests!

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner February 24, 2021 01:57
marcomangano
marcomangano previously approved these changes Feb 24, 2021
@eirikurj
Copy link
Contributor

@nwu63 I am guessing that you did not run or test this based on the "There are no tests!" description. The string here (the block name) is not a str but a byte literal read/written from the cgns library. I will push a fix that.

@marcomangano
Copy link
Contributor

@eirikurj so you tested this? Is this good to be merged?

@eirikurj
Copy link
Contributor

Yes this is tested and good to merge. Merging.

@eirikurj eirikurj merged commit fff3947 into master Feb 24, 2021
@eirikurj eirikurj deleted the fix-regex branch February 24, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning
3 participants